linux-kernel - Re: [PATCH 6.0 0000/1066] 6.0.16-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Dec 2022 21:52:03 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Conor Dooley <conor@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de
Subject: Re: [PATCH 6.0 0000/1066] 6.0.16-rc2 review

On Sat, Dec 31, 2022 at 12:09:13AM +0000, Conor Dooley wrote:
> Hey Greg,
> 
> On Fri, Dec 30, 2022 at 10:49:23AM +0100, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.0.16 release.
> > There are 1066 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sun, 01 Jan 2023 09:38:41 +0000.
> > Anything received after that time might be too late.
> 
> > Paulo Alcantara <pc@....nz>
> >     cifs: improve symlink handling for smb2+
> 
> This patch here appears to fail allmodconfig + LLVM on RISC-V:
> ../fs/cifs/smb2inode.c:419:4: error: variable 'idata' is uninitialized when used here [-Werror,-Wuninitialized]
>                         idata->symlink_target = kstrdup(cfile->symlink_target, GFP_KERNEL);
>                         ^~~~~
> ../fs/cifs/smb2inode.c:76:35: note: initialize the variable 'idata' to silence this warning
>         struct cifs_open_info_data *idata;
>                                          ^
>                                           = NULL
> 1 error generated.

Fixed with upstream commit 69ccafdd35cdf ("cifs: fix uninitialised var in
smb2_compound_op()").

Guenter

> 
> It looks like this was reported as a smatch error on Christmas Day:
> https://lore.kernel.org/all/202212250020.fyWQFNzF-lkp@intel.com/
> 
> Given the day in question, missing that report seems pretty
> understandable :)
> 
> I tried to see if this had been reported already against the patches
> themselves, rather than Sasha's queue, but given the size of the patchset
> I may have missed it. Apologies for the noise if I have.
> 
> Thanks,
> Conor.
>