linux-kernel - Re: [PATCH 00/20] staging: r8188eu: some xmit cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Dec 2022 11:08:50 +0100
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Michael Straube <straube.linux@...il.com>,
        Pavel Skripkin <paskripkin@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/20] staging: r8188eu: some xmit cleanups

On 12/30/22 19:06, Martin Kaiser wrote:
> Start cleaning up the code that transmits data frames to the dongle
> via USB.
> 
> This should be applied on top of the "merge public action functions"
> series.
> 
> Martin Kaiser (20):
>    staging: r8188eu: make xmitframe_swencrypt a void function
>    staging: r8188eu: remove some unused CAM defines
>    staging: r8188eu: cmd_seq is write-only
>    staging: r8188eu: return immediately if we're not meant to encrypt
>    staging: r8188eu: remove unused parameter
>    staging: r8188eu: simplify rtl8188eu_xmit_tasklet
>    staging: r8188eu: remove rtl8188eu_init_xmit_priv
>    staging: r8188eu: remove duplicate psta check
>    staging: r8188eu: simplify frame type check
>    staging: r8188eu: simplify rtw_make_wlanhdr's error handling
>    staging: r8188eu: clean up qos_option setting
>    staging: r8188eu: remove unused bpending array
>    staging: r8188eu: remove unused dma_transfer_addr
>    staging: r8188eu: bm_pending is not used
>    staging: r8188eu: terminate_xmitthread_sema is not used
>    staging: r8188eu: tx_retevt semaphore is not used
>    staging: r8188eu: remove unnecessary rtw_free_xmitframe call
>    staging: r8188eu: phwxmit parameter is unused
>    staging: r8188eu: rtw_init_hwxmits is not needed
>    staging: r8188eu: we use a constant number of hw_xmit entries
> 
>   drivers/staging/r8188eu/core/rtw_cmd.c        |   4 -
>   drivers/staging/r8188eu/core/rtw_xmit.c       | 239 ++++++++----------
>   drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |  27 +-
>   drivers/staging/r8188eu/hal/usb_ops_linux.c   |  14 +-
>   .../staging/r8188eu/include/rtl8188e_spec.h   |  21 --
>   .../staging/r8188eu/include/rtl8188e_xmit.h   |   4 +-
>   drivers/staging/r8188eu/include/rtw_cmd.h     |   1 -
>   drivers/staging/r8188eu/include/rtw_xmit.h    |   9 +-
>   8 files changed, 116 insertions(+), 203 deletions(-)
> 
Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com> # Edimax N150