linux-kernel - Re: [RFC PATCH v2 03/18] ntfs: Undeprecate iocharset= mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230101230253.qhhku7d42kyrbkst@pali>
Date:   Mon, 2 Jan 2023 00:02:53 +0100
From:   Pali Rohár <pali@...nel.org>
To:     Kari Argillander <kari.argillander@...il.com>
Cc:     linux-fsdevel@...r.kernel.org,
        linux-ntfs-dev@...ts.sourceforge.net, linux-cifs@...r.kernel.org,
        jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Jan Kara <jack@...e.cz>, "Theodore Y . Ts'o" <tytso@....edu>,
        Anton Altaparmakov <anton@...era.com>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Luis de Bethencourt <luisbg@...nel.org>,
        Salah Triki <salah.triki@...il.com>,
        Steve French <sfrench@...ba.org>, Paulo Alcantara <pc@....nz>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>, Dave Kleikamp <shaggy@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Pavel Machek <pavel@....cz>,
        Christoph Hellwig <hch@...radead.org>,
        Viacheslav Dubeyko <slava@...eyko.com>
Subject: Re: [RFC PATCH v2 03/18] ntfs: Undeprecate iocharset= mount option

On Sunday 01 January 2023 20:06:05 Pali Rohár wrote:
> On Sunday 01 January 2023 21:02:46 Kari Argillander wrote:
> > 26.12.2022 klo 16.22 Pali Rohár (pali@...nel.org) wrote:
> > >
> > > Other fs drivers are using iocharset= mount option for specifying charset.
> > > So mark iocharset= mount option as preferred and deprecate nls= mount
> > > option.
> > 
> > snip.
> > 
> > > diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
> > 
> > snip.
> > 
> > > @@ -218,10 +213,10 @@ static bool parse_options(ntfs_volume *vol, char *opt)
> > >                 } else if (!strcmp(p, "utf8")) {
> > >                         bool val = false;
> > >                         ntfs_warning(vol->sb, "Option utf8 is no longer "
> > > -                                  "supported, using option nls=utf8. Please "
> > > -                                  "use option nls=utf8 in the future and "
> > > -                                  "make sure utf8 is compiled either as a "
> > > -                                  "module or into the kernel.");
> > > +                                  "supported, using option iocharset=utf8. "
> > > +                                  "Please use option iocharset=utf8 in the "
> > > +                                  "future and make sure utf8 is compiled "
> > > +                                  "either as a module or into the kernel.");
> > 
> > We do not have to make sure utf8 is compiled anymore as it "always is" right?
> 
> Yes, right, we have always utf8 support compiled-in.
> Second part of that warning message should be dropped.

Ok, this is truth after patch 15/18. So info about compiled module
should be dropped in patch 15/18, not in this one.

> > >                         if (!v || !*v)
> > >                                 val = true;
> > >                         else if (!simple_getbool(v, &val))