[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 1 Jan 2023 09:51:24 +0200
From: Mike Rapoport <rppt@...nel.org>
To: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
Cc: jan.kiszka@...mens.com, kbingham@...nel.org,
akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
mingo@...hat.com, x86@...nel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, vbabka@...e.cz
Subject: Re: [PATCH] scripts/gdb: add mm introspection utils
On Sat, Dec 31, 2022 at 08:14:30PM +0300, Dmitrii Bundin wrote:
> On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport <rppt@...nel.org> wrote:
> >
> > The commit message does not mention it's x86-specific.
> > Not sure how gdb scripts handle per-arch functionality, but at the very
> > least this should be stated in the commit message.
> >
> Thanks for pointing this out. Will fix it. I put the command's code
> under the if utils.is_target_arch("x86") ... else
> gdb.GdbError("Virtual address translation is not supported for this
> arch") as it's done in other scripts and have plans to implement the
> same functionality for ARM in the foreseeable future.
>
> > Any particular reason to make it ALL CAPS?
> Actually, no. Do you propose to reformat the output with a lower case?
I like lower case more :)
I'd also put the bit number first and would align the columns, e.g
something like:
bit 0: entry present : true
bit 1: read/write access allowed : true
bit 2: user access allowed : true
bit 3: page level write through : false
bit 4: page level cache disabled : false
bit 5: entry has been accessed : true
bit 7: page size : false
bit 11: restart to ordinary : false
bit 63: execute disable : true
--
Sincerely yours,
Mike.
Powered by blists - more mailing lists