linux-kernel - RE: [PATCH v1 1/1] mei: pxp: Use correct macros to initialize uuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 1 Jan 2023 12:27:37 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Lubart, Vitaly" <vitaly.lubart@...el.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>
Subject: RE: [PATCH v1 1/1] mei: pxp: Use correct macros to initialize uuid_le


> 
> GUID_INIT() is for internal guid_t type and shouldn't be used for the uuid_le.
> I.o.w. relying on the implementation details is layering violation. Use correct
> macros to initialize uuid_le.
> 
> Fixes: c2004ce99ed7 ("mei: pxp: export pavp client to me client bus")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@...el.com> 

> ---
>  drivers/misc/mei/pxp/mei_pxp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/pxp/mei_pxp.c
> b/drivers/misc/mei/pxp/mei_pxp.c index 8dd09b1722eb..7ee1fa7b1cb3
> 100644
> --- a/drivers/misc/mei/pxp/mei_pxp.c
> +++ b/drivers/misc/mei/pxp/mei_pxp.c
> @@ -238,8 +238,8 @@ static void mei_pxp_remove(struct mei_cl_device
> *cldev)  }
> 
>  /* fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1 : PAVP GUID*/ -#define
> MEI_GUID_PXP GUID_INIT(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \
> -			       0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1)
> +#define MEI_GUID_PXP UUID_LE(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \
> +			     0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1)
> 
>  static struct mei_cl_device_id mei_pxp_tbl[] = {
>  	{ .uuid = MEI_GUID_PXP, .version = MEI_CL_VERSION_ANY },
> --
> 2.35.1