lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <01ac01d91e66$e18d6da0$a4a848e0$@samsung.com> Date: Mon, 2 Jan 2023 10:28:30 +0530 From: "Alim Akhtar" <alim.akhtar@...sung.com> To: "'Bean Huo'" <beanhuo@...pp.de>, <avri.altman@....com>, <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <beanhuo@...ron.com>, <bvanassche@....org>, <quic_cang@...cinc.com>, <quic_xiaosenh@...cinc.com> Cc: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "'kernel test robot'" <lkp@...el.com> Subject: RE: [PATCH ] scsi: ufs: core: bsg: Fix sometimes-uninitialized warnings Hi Bean, >-----Original Message----- >From: Bean Huo [mailto:beanhuo@...pp.de] >Sent: Saturday, December 31, 2022 8:34 PM >To: alim.akhtar@...sung.com; avri.altman@....com; jejb@...ux.ibm.com; >martin.petersen@...cle.com; beanhuo@...ron.com; bvanassche@....org; >quic_cang@...cinc.com; quic_xiaosenh@...cinc.com >Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; kernel test >robot <lkp@...el.com> >Subject: [PATCH ] scsi: ufs: core: bsg: Fix sometimes-uninitialized warnings > >From: Bean Huo <beanhuo@...ron.com> > >Compilation complains that two possible variables are used without >initialization: > >drivers/ufs/core/ufs_bsg.c:112:6: warning: variable 'sg_cnt' is used >uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] >drivers/ufs/core/ufs_bsg.c:112:6: warning: variable 'sg_list' is used >uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > >Fix both warnings by adding initialization with sg_cnt = 0, sg_list = NULL. > >Fixes: 6ff265fc5ef6 ("scsi: ufs: core: bsg: Add advanced RPMB support in >ufs_bsg") >Signed-off-by: Bean Huo <beanhuo@...ron.com> >Reported-by: kernel test robot <lkp@...el.com> >Reported-by: Xiaosen He <quic_xiaosenh@...cinc.com> >--- Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com> >Hi Martin, > >This patch is to fix two compilation warnings introduced by my commit: >6ff265fc5ef6 ("scsi: ufs: core: bsg: Add advanced RPMB support in ufs_bsg"). > >Apologies for this. > >--- > drivers/ufs/core/ufs_bsg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/ufs/core/ufs_bsg.c b/drivers/ufs/core/ufs_bsg.c index >0044029bcf7b..0d38e7fa34cc 100644 >--- a/drivers/ufs/core/ufs_bsg.c >+++ b/drivers/ufs/core/ufs_bsg.c >@@ -70,9 +70,9 @@ static int ufs_bsg_exec_advanced_rpmb_req(struct >ufs_hba *hba, struct bsg_job *j > struct ufs_rpmb_reply *rpmb_reply = job->reply; > struct bsg_buffer *payload = NULL; > enum dma_data_direction dir; >- struct scatterlist *sg_list; >+ struct scatterlist *sg_list = NULL; > int rpmb_req_type; >- int sg_cnt; >+ int sg_cnt = 0; > int ret; > int data_len; > >-- >2.25.1
Powered by blists - more mailing lists