linux-kernel - Re: usb: gadget: f_uac2: Fix incorrect increment of bNumEndpoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <27041361-dcbd-a50c-3f3a-f774c8cf05b8@quicinc.com>
Date:   Mon, 2 Jan 2023 16:16:09 +0530
From:   Prashanth K <quic_prashk@...cinc.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Pavel Hofman <pavel.hofman@...tera.com>,
        Joe Perches <joe@...ches.com>, Julian Scheel <julian@...st.de>,
        Colin Ian King <colin.i.king@...il.com>,
        Pratham Pratap <quic_ppratap@...cinc.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: usb: gadget: f_uac2: Fix incorrect increment of bNumEndpoints



On 23-12-22 08:26 pm, Greg Kroah-Hartman wrote:
> On Wed, Nov 23, 2022 at 02:18:10PM +0530, Prashanth K wrote:
>> Currently connect/disconnect of USB cable calls afunc_bind and
>> eventually increments the bNumEndpoints. And performing multiple
>> plugin/plugout will incorrectly increment bNumEndpoints on the
>> next plug-in leading to invalid configuration of descriptor and
>> hence enumeration failure.
>>
>> Fix this by resetting the value of bNumEndpoints to 1 on every
>> afunc_bind call.
>>
>> Signed-off-by: Pratham Pratap <quic_ppratap@...cinc.com>
>> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
> 
> Who authored this, Pratham or you?
>
Its authored by Pratham, but I'm upstreaming it.
> And why no "[PATCH]" in the subject line?
> 
I was under the impression that [PATCH] is not used for v1.
Will fix this in next patch

> What commit id does this fix?
> 
Will add the Fixes tag also in next patch
> thanks,
> 
> greg k-h
Thanks
Prashanth K