linux-kernel - [PATCH v2] mfd: rk808: re-add rk808-clkout to RK818

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230102111147.2580861-1-tom@tom-fitzhenry.me.uk>
Date:   Mon,  2 Jan 2023 22:11:47 +1100
From:   Tom Fitzhenry <tom@...-fitzhenry.me.uk>
To:     Lee Jones <lee@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>
Cc:     Ondrej Jirman <megi@....cz>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Martijn Braam <martijn@...xit.nl>,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Tom Fitzhenry <tom@...-fitzhenry.me.uk>
Subject: [PATCH v2] mfd: rk808: re-add rk808-clkout to RK818

Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.

This line was removed in commit 3633daacea2e
("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.

Changes in v2:
- Add a Fixes tag (Javier Martinez Canillas).
- Add Javier Martinez Canillas's Reviewed-by tag.
- Add Neil Armstrong's Acked-by tag.

Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances")
Signed-off-by: Tom Fitzhenry <tom@...-fitzhenry.me.uk>
Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
Acked-by: Neil Armstrong <neil.armstrong@...aro.org>
---
 drivers/mfd/rk808.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
index f44fc3f080a8..0f22ef61e817 100644
--- a/drivers/mfd/rk808.c
+++ b/drivers/mfd/rk808.c
@@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
 };
 
 static const struct mfd_cell rk818s[] = {
+	{ .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
 	{ .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
 	{
 		.name = "rk808-rtc",

base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
-- 
2.38.1