linux-kernel - Re: [PATCH] irqchip: Fix refcount leak in platform_irqchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fa4699cc0b1b17943d4c67e53c432a4@kernel.org>
Date:   Mon, 02 Jan 2023 12:20:02 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Saravana Kannan <saravanak@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: Fix refcount leak in platform_irqchip_probe

On 2023-01-02 12:13, Miaoqian Lin wrote:
> of_irq_find_parent() returns a node pointer with refcount incremented,
> We should use of_node_put() on it when not needed anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: f8410e626569 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END
> and IRQCHIP_MATCH helper macros")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Please stop sending these patches one by one.

Send a series covering the whole of the irqchip subsystem, once
you have looked at all the drivers.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...