linux-kernel - Re: [PATCH v10 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7LX5f7Zc52d5OLH@pendragon.ideasonboard.com>
Date:   Mon, 2 Jan 2023 15:11:01 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Rahul T R <r-ravikumar@...com>
Cc:     dri-devel@...ts.freedesktop.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, tomi.valkeinen@...asonboard.com,
        andrzej.hajda@...el.com, narmstrong@...libre.com,
        robert.foss@...aro.org, jonas@...boo.se, jernej.skrabec@...il.com,
        airlied@...ux.ie, daniel@...ll.ch, p.zabel@...gutronix.de,
        linux-kernel@...r.kernel.org, jpawar@...ence.com,
        sjakhade@...ence.com, mparab@...ence.com, a-bhatia1@...com,
        devicetree@...r.kernel.org, vigneshr@...com, lee.jones@...aro.org,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v10 2/5] dt-bindings: display: bridge: cdns,dsi: Add
 compatible for dsi on j721e

Hi Rahul,

Thank you for the patch.

On Mon, Jan 02, 2023 at 03:39:39PM +0530, Rahul T R wrote:
> Add compatible to support dsi bridge on j721e
> 
> Signed-off-by: Rahul T R <r-ravikumar@...com>
> Reviewed-by: Rob Herring <robh@...nel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  .../bindings/display/bridge/cdns,dsi.yaml     | 25 ++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> index 3161c33093c1..23060324d16e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml
> @@ -16,9 +16,15 @@ properties:
>    compatible:
>      enum:
>        - cdns,dsi
> +      - ti,j721e-dsi
>  
>    reg:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description:
> +          Register block for controller's registers.
> +      - description:
> +          Register block for wrapper settings registers in case of TI J7 SoCs.
>  
>    clocks:
>      items:
> @@ -67,6 +73,23 @@ properties:
>  allOf:
>    - $ref: ../dsi-controller.yaml#
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ti,j721e-dsi
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +          maxItems: 2
> +        power-domains:
> +          maxItems: 1
> +    else:
> +      properties:
> +        reg:
> +          maxItems: 1
> +
>  required:
>    - compatible
>    - reg

-- 
Regards,

Laurent Pinchart