linux-kernel - Re: [PATCH 5/6] arm64: dts: qcom: sm8250-mtp: fix wcd938x codec node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7L1r7ehoo68ZxJQ@hovoldconsulting.com>
Date:   Mon, 2 Jan 2023 16:18:07 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm8250-mtp: fix wcd938x codec node

On Mon, Jan 02, 2023 at 04:09:14PM +0100, Krzysztof Kozlowski wrote:
> On 02/01/2023 16:03, Johan Hovold wrote:
> > On Mon, Jan 02, 2023 at 01:20:03PM +0100, Krzysztof Kozlowski wrote:
> >> On 02/01/2023 11:50, Johan Hovold wrote:
> >>> The wcd938x codec is not a memory-mapped device and does not belong
> >>> under the soc node.
> >>>
> >>> Move the node to the root node to avoid DT validation failures.
> >>>
> >>> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> >>> ---
> >>>  arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 40 ++++++++++++-------------
> >>>  1 file changed, 19 insertions(+), 21 deletions(-)
> >>
> >> Don't you base on some older tree? It was alreadt moved. Maybe other
> >> changes were also implemented...
> > 
> > If you've moved this node is hasn't made it into linux-next (or the qcom
> > tree) yet.
> 
> So you need to update your tree/rebase as this is already in Qualcomm
> tree. There was no linux-next release since a week, so that's not a
> solution.

As I wrote above, it's not in the qcom tree either.

Johan