linux-kernel - Re: [PATCH 6/6] arm64: dts: qcom: sm8450-hdk: fix wcd938x codec node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <582a53a4-991c-5596-d8c8-2c1c09997874@linaro.org>
Date:   Mon, 2 Jan 2023 16:24:19 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Johan Hovold <johan+linaro@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: sm8450-hdk: fix wcd938x codec node

On 02/01/2023 16:18, Johan Hovold wrote:
> On Mon, Jan 02, 2023 at 04:09:59PM +0100, Krzysztof Kozlowski wrote:
>> On 02/01/2023 16:05, Johan Hovold wrote:
>>> On Mon, Jan 02, 2023 at 01:24:34PM +0100, Krzysztof Kozlowski wrote:
>>>> On 02/01/2023 13:23, Krzysztof Kozlowski wrote:
>>>>> On 02/01/2023 11:50, Johan Hovold wrote:
>>>>>> The wcd938x codec is not a memory-mapped device and does not belong
>>>>>> under the soc node.
>>>>>>
>>>>>> Move the node to the root node to avoid DT validation failures.
>>>>>>
>>>>>> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
>>>>>> ---
>>>>>>  arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 52 ++++++++++++-------------
>>>>>>  1 file changed, 25 insertions(+), 27 deletions(-)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>>>>>> index 4de3e1f1c39c..217b2c654745 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>>>>>> @@ -17,6 +17,31 @@ aliases {
>>>>>>  		serial0 = &uart7;
>>>>>>  	};
>>>>>>  
>>>>>> +	wcd938x: codec {
>>>>>
>>>>> Let's call it audio-codec and put it somewhere ordered alphabetically.
>>>>> This avoids useless reshuffles immediately. Moving things back and forth
>>>>> does not make sense.
>>>>
>>>> Eh, on the other hand SM8250-MTP uses name codec so maybe the rename in
>>>> SC8280xp should be dropped.
>>>
>>> Nah, let's go with audio-codec. Your MTP change hasn't been merged yet
>>> so we can still drop or respin that one.
>>
>> It was, ~5 days ago, so please rebase.
> 
> Again, not in the qcom tree yet AFAICS.

It's clearly visible there, since a week, so please update your trees
and rebase.

Best regards,
Krzysztof