linux-kernel - Re: [PATCH v3] selftest/vm: add mremap expand merge offset test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7MBqfYv54rY48Wi@lucifer>
Date:   Mon, 2 Jan 2023 16:09:13 +0000
From:   Lorenzo Stoakes <lstoakes@...il.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, Vlastimil Babka <vbabka@...e.cz>,
        Jakub Matena <matenajakub@...il.com>,
        Matthew Wilcox <willy@...radead.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Michal Hocko <mhocko@...nel.org>
Subject: Re: [PATCH v3] selftest/vm: add mremap expand merge offset test

On Mon, Jan 02, 2023 at 05:03:31PM +0100, David Hildenbrand wrote:

> With the exit() in place, the else branch is implicit and the else can be
> dropped.

Good point, we'll go to a v4 then :) that does neaten things up
actually. Hopefully this should suffice!

Agree with your previous point about tooling by the way, it would be good to
have some more functionality in place that wraps these places where you feel the
need to goto.