linux-kernel - Re: [PATCH v2] kcsan: test: don't put the expect array on the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMo8BfJRb3aqkd6sdeT5DsDQAgZP4BBHCQgToCfN+Fxj6s-NuA@mail.gmail.com>
Date:   Mon, 2 Jan 2023 08:56:24 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Marco Elver <elver@...gle.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>, kasan-dev@...glegroups.com,
        linux-kernel@...r.kernel.org, linux-xtensa@...ux-xtensa.org
Subject: Re: [PATCH v2] kcsan: test: don't put the expect array on the stack

On Sun, Jan 1, 2023 at 11:00 PM Marco Elver <elver@...gle.com> wrote:
>
> On Sat, 31 Dec 2022 at 01:45, Max Filippov <jcmvbkbc@...il.com> wrote:
> >
> > Size of the 'expect' array in the __report_matches is 1536 bytes, which
> > is exactly the default frame size warning limit of the xtensa
> > architecture.
> > As a result allmodconfig xtensa kernel builds with the gcc that does not
> > support the compiler plugins (which otherwise would push the said
> > warning limit to 2K) fail with the following message:
> >
> >   kernel/kcsan/kcsan_test.c:257:1: error: the frame size of 1680 bytes
> >     is larger than 1536 bytes
> >
> > Fix it by dynamically alocating the 'expect' array.
> >
> > Signed-off-by: Max Filippov <jcmvbkbc@...il.com>
>
> Reviewed-by: Marco Elver <elver@...gle.com>
> Tested-by: Marco Elver <elver@...gle.com>
>
> Can you take this through the xtensa tree?

Sure. Thanks for your review and testing.

-- Max