linux-kernel - Re: [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <af5dd2c21d7805315e719f8b0fd163bcaa6aea39.camel@pengutronix.de>
Date:   Mon, 02 Jan 2023 18:40:58 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Johannes Berg <johannes@...solutions.net>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding

On Do, 2022-12-22 at 11:20 +0100, Krzysztof Kozlowski wrote:
> On 21/12/2022 11:48, Philipp Zabel wrote:
> > Add a device tree binding document for GPIO controlled rfkill switches.
> > The name, type, shutdown-gpios and reset-gpios properties are the same
> > as defined for ACPI.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> You missed several maintainers. Resend.

Thank you for the review, I've sent a v2:

https://lore.kernel.org/all/20230102-rfkill-gpio-dt-v2-0-d1b83758c16d@pengutronix.de/T

[...]
> 
> 
> > +  shutdown-gpios:
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> 
> Reset of rfkill? It seems entire binding is a workaround of missing
> reset in your device. I don't think this is suitable for binding.

I've dropped the reset-gpios property. The device I would like to
control with this is the 'wireless disable' pin of an M.2 connector.

regards
Philipp