linux-kernel - Re: [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 02 Jan 2023 19:27:31 +0100
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Hector Martin <marcan@...can.st>,
        Aditya Garg <gargaditya08@...e.com>, <aspriel@...il.com>,
        <hante.meuleman@...adcom.com>, <kvalo@...nel.org>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <lina@...hilina.net>,
        <franky.lin@...adcom.com>
CC:     Orlando Chamberlain <redecorating@...tonmail.com>,
        <brcm80211-dev-list@...adcom.com>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <linux-wireless@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Asahi Linux <asahi@...ts.linux.dev>
Subject: Re: [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips

On January 2, 2023 4:15:41 PM Hector Martin <marcan@...can.st> wrote:

> On 02/01/2023 23.40, Aditya Garg wrote:
>> From: Aditya Garg <gargaditya08@...e.com>
>>
>> Commit 'dce45ded7619' added support for 89459 chip pcie device. It uses the
>> BRCM4355 chip which is also found in Apple hardware. However this commit
>> causes conflicts in the firmware naming between Apple hardware, which
>> supports OTP and other non-Apple hardwares. So, this patch makes these
>> Apple chips use their own firmware table so as to avoid possible conflicts
>> like these in the future.
>
> I think my reply to Arend flew over your head.
>
> My point was that I'd rather have the Broadcom/Cypress people actually
> answer my question so we can figure out how to do this *properly*,
> instead of doing "safer-but-dumb" things (like this patch) because we
> just don't have the information to do it properly.

Fair enough. Can you accurately (re)state your question and I will try to 
answer it.

Regards,
Arend

> - Hector




Download attachment "smime.p7s" of type "application/pkcs7-signature" (4219 bytes)