linux-kernel - Re: [PATCH 14/14] drm/panel-xinpeng-xpp055c272: Drop custom DSI write macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c96f9d0b-2838-fc8a-cf2b-47c5be463ff1@redhat.com>
Date:   Mon, 2 Jan 2023 20:08:11 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH 14/14] drm/panel-xinpeng-xpp055c272: Drop custom DSI write
 macro

On 1/2/23 19:53, Sam Ravnborg wrote:

[...]

>>  }
>>  
>> -#define dsi_generic_write_seq(dsi, cmd, seq...) do {			\
>> -		static const u8 b[] = { cmd, seq };			\
>> -		int ret;						\
>> -		ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b));	\
> Notice that this is *dcs*
>

I missed that! Thanks a lot for catching this inconsistency in the naming.

[...]

>> -	dsi_generic_write_seq(dsi, XPP055C272_CMD_SETEXTC, 0xf1, 0x12, 0x83);
>> -	dsi_generic_write_seq(dsi, XPP055C272_CMD_SETMIPI,
>> +	mipi_dsi_generic_write_seq(dsi, XPP055C272_CMD_SETEXTC, 0xf1, 0x12, 0x83);
> This is wrong - here you should use mipi_dsi_dcs_write_seq()
> Likewise for the rest of the file.
>

Agreed.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat