linux-kernel - Re: [PATCH v2] power: supply: rk817: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 2 Jan 2023 23:18:28 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Chris Morgan <macroalpha82@...il.com>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2] power: supply: rk817: Fix unsigned comparison with
 less than zero

Hi,

On Thu, Dec 15, 2022 at 01:04:14PM -0600, Chris Morgan wrote:
> On Wed, Dec 14, 2022 at 11:23:16AM +0800, Jiapeng Chong wrote:
> > The tmp is defined as u32 type, which results in invalid processing of
> > tmp<0 in function rk817_read_or_set_full_charge_on_boot(). Therefore,
> > drop the comparison.
> > 
> > drivers/power/supply/rk817_charger.c:828 rk817_read_or_set_full_charge_on_boot() warn: unsigned 'tmp' is never less than zero.
> > drivers/power/supply/rk817_charger.c:788 rk817_read_or_set_full_charge_on_boot() warn: unsigned 'tmp' is never less than zero.
> > 
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3444
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> 
> Looks good to me, thank you.
> 
> Tested-by: Chris Morgan <macromorgan@...mail.com>

Thanks, queued to power-supply's fixes branch.

-- Sebastian

> > ---
> > Changes in v2:
> >   -Drop the comparison 'tmp<0'.
> > 
> >  drivers/power/supply/rk817_charger.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> > index 4f9c1c417916..36f807b5ec44 100644
> > --- a/drivers/power/supply/rk817_charger.c
> > +++ b/drivers/power/supply/rk817_charger.c
> > @@ -785,8 +785,6 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger,
> >  		regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_Q_PRES_H3,
> >  				 bulk_reg, 4);
> >  		tmp = get_unaligned_be32(bulk_reg);
> > -		if (tmp < 0)
> > -			tmp = 0;
> >  		boot_charge_mah = ADC_TO_CHARGE_UAH(tmp,
> >  						    charger->res_div) / 1000;
> >  		/*
> > @@ -825,8 +823,6 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger,
> >  	regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_Q_PRES_H3,
> >  			 bulk_reg, 4);
> >  	tmp = get_unaligned_be32(bulk_reg);
> > -	if (tmp < 0)
> > -		tmp = 0;
> >  	boot_charge_mah = ADC_TO_CHARGE_UAH(tmp, charger->res_div) / 1000;
> >  	regmap_bulk_read(rk808->regmap, RK817_GAS_GAUGE_OCV_VOL_H,
> >  			 bulk_reg, 2);
> > -- 
> > 2.20.1.7.g153144c
> > 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)