[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8f433e5-fb46-d3b8-431b-4bddcc938f6b@linux.intel.com>
Date: Tue, 3 Jan 2023 20:56:40 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: lizhe <sensor1010@....com>
cc: jirislaby@...nel.org, gregkh@...uxfoundation.org,
linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] serial: linflexuart: remove redundant uart type
_assignment_
On Tue, 3 Jan 2023, lizhe wrote:
> in linflex_config_port() the member variable type will be
Rmoeve these extra spaces and start right from the leftmost column.
And don't include the underscores (_) into the shortlog around assignment.
Jiri just used the underscores to highlight for you what he considered
important part to be corrected.
> assigned again. see linflex_connfig_port()
>
> Signed-off-by: lizhe <sensor1010@....com>
> Acked-by: Jiri Slaby <jslaby@...e.com>
> ---
When sending version xx, please remember to include the list of changes
made per version (they go here below the first --- marker, see mailinglist
archives for format examples if you don't know that alread).
--
i.
> drivers/tty/serial/fsl_linflexuart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 6fc21b6684e6..34400cc6ac7f 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
> return PTR_ERR(sport->membase);
>
> sport->dev = &pdev->dev;
> - sport->type = PORT_LINFLEXUART;
> sport->iotype = UPIO_MEM;
> sport->irq = platform_get_irq(pdev, 0);
> sport->ops = &linflex_pops;
>
Powered by blists - more mailing lists