linux-kernel - Re: [PATCH] pipe: use __pipe_{lock,unlock} instead of spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202301031231.BKjEFL1w-lkp@intel.com>
Date:   Tue, 3 Jan 2023 12:30:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hongchen Zhang <zhanghongchen@...ngson.cn>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kuniyuki Iwashima <kuniyu@...zon.co.jp>,
        Luis Chamberlain <mcgrof@...nel.org>,
        David Howells <dhowells@...hat.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Randy Dunlap <rdunlap@...radead.org>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pipe: use __pipe_{lock,unlock} instead of spinlock

Hi Hongchen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on c8451c141e07a8d05693f6c8d0e418fbb4b68bb7]

url:    https://github.com/intel-lab-lkp/linux/commits/Hongchen-Zhang/pipe-use-__pipe_-lock-unlock-instead-of-spinlock/20230103-110504
base:   c8451c141e07a8d05693f6c8d0e418fbb4b68bb7
patch link:    https://lore.kernel.org/r/20230103030329.20252-1-zhanghongchen%40loongson.cn
patch subject: [PATCH] pipe: use __pipe_{lock,unlock} instead of spinlock
config: x86_64-rhel-8.3-kselftests
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/74b922b9da7ec76cce2065114d07afc5065b2df9
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hongchen-Zhang/pipe-use-__pipe_-lock-unlock-instead-of-spinlock/20230103-110504
        git checkout 74b922b9da7ec76cce2065114d07afc5065b2df9
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash net/tls/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/splice.h:12,
                    from net/tls/tls_sw.c:41:
   include/linux/pipe_fs_i.h: In function '__pipe_lock':
>> include/linux/pipe_fs_i.h:228:41: error: 'I_MUTEX_PARENT' undeclared (first use in this function)
     228 |         mutex_lock_nested(&pipe->mutex, I_MUTEX_PARENT);
         |                                         ^~~~~~~~~~~~~~
   include/linux/pipe_fs_i.h:228:41: note: each undeclared identifier is reported only once for each function it appears in


vim +/I_MUTEX_PARENT +228 include/linux/pipe_fs_i.h

   224	
   225	/* Pipe lock and unlock operations */
   226	static inline void __pipe_lock(struct pipe_inode_info *pipe)
   227	{
 > 228		mutex_lock_nested(&pipe->mutex, I_MUTEX_PARENT);
   229	}
   230	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (171966 bytes)