linux-kernel - Re: [PATCH 1/4] dt-bindings: PCI: qcom: add MSM8998 specific compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230103203915.GA1020424@bhelgaas>
Date:   Tue, 3 Jan 2023 14:39:15 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Stanimir Varbanov <svarbanov@...sol.com>,
        linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: PCI: qcom: add MSM8998 specific
 compatible

On Tue, Nov 15, 2022 at 01:53:07PM +0100, Krzysztof Kozlowski wrote:
> Add new compatible for MSM8998 (compatible with MSM8996) to allow
> further customizing if needed and to accurately describe the hardware.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Hi Krzysztof,

Would you mind splitting this into two patches?

  - Convert "compatible:" from enum: to oneOf:
  - Add MSM8998

Having them combined makes the history a little bit harder to follow.

Bjorn

> ---
>  .../devicetree/bindings/pci/qcom,pcie.yaml    | 42 ++++++++++---------
>  1 file changed, 23 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 54f07852d279..0411e2e67661 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -16,25 +16,29 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,pcie-ipq8064
> -      - qcom,pcie-ipq8064-v2
> -      - qcom,pcie-apq8064
> -      - qcom,pcie-apq8084
> -      - qcom,pcie-msm8996
> -      - qcom,pcie-ipq4019
> -      - qcom,pcie-ipq8074
> -      - qcom,pcie-qcs404
> -      - qcom,pcie-sa8540p
> -      - qcom,pcie-sc7280
> -      - qcom,pcie-sc8180x
> -      - qcom,pcie-sc8280xp
> -      - qcom,pcie-sdm845
> -      - qcom,pcie-sm8150
> -      - qcom,pcie-sm8250
> -      - qcom,pcie-sm8450-pcie0
> -      - qcom,pcie-sm8450-pcie1
> -      - qcom,pcie-ipq6018
> +    oneOf:
> +      - enum:
> +          - qcom,pcie-ipq8064
> +          - qcom,pcie-ipq8064-v2
> +          - qcom,pcie-apq8064
> +          - qcom,pcie-apq8084
> +          - qcom,pcie-msm8996
> +          - qcom,pcie-ipq4019
> +          - qcom,pcie-ipq8074
> +          - qcom,pcie-qcs404
> +          - qcom,pcie-sa8540p
> +          - qcom,pcie-sc7280
> +          - qcom,pcie-sc8180x
> +          - qcom,pcie-sc8280xp
> +          - qcom,pcie-sdm845
> +          - qcom,pcie-sm8150
> +          - qcom,pcie-sm8250
> +          - qcom,pcie-sm8450-pcie0
> +          - qcom,pcie-sm8450-pcie1
> +          - qcom,pcie-ipq6018
> +      - items:
> +          - const: qcom,pcie-msm8998
> +          - const: qcom,pcie-msm8996
>  
>    reg:
>      minItems: 4
> -- 
> 2.34.1
>