lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANiq72k8LSqsnWNd_aa-M1=rMNLWD7KJWrK6Pv0Waq15Exv59g@mail.gmail.com> Date: Tue, 3 Jan 2023 21:44:49 +0100 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: Masahiro Yamada <masahiroy@...nel.org> Cc: linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Nicolas Schier <nicolas@...sle.eu>, Tom Rix <trix@...hat.com>, Wedson Almeida Filho <wedsonaf@...il.com>, llvm@...ts.linux.dev, rust-for-linux@...r.kernel.org Subject: Re: [PATCH 1/6] kbuild: specify output names separately for each emission type from rustc On Sat, Dec 31, 2022 at 7:42 AM Masahiro Yamada <masahiroy@...nel.org> wrote: > > $ make -j$(nproc) samples/rust/rust_minimal.o samples/rust/rust_minimal.rsi \ > samples/rust/rust_minimal.s samples/rust/rust_minimal.ll Yeah, we were testing the single targets, but not multiple at once, thanks! > + --emit=dep-info=$(depfile) --emit=obj=$@ --emit=metadata=$(dir $@)$(patsubst %.o,lib%.rmeta,$(notdir $@)) \ Perhaps a newline here to avoid the lengthy line? > hostc_flags = -Wp,-MMD,$(depfile) $(_hostc_flags) > hostcxx_flags = -Wp,-MMD,$(depfile) $(_hostcxx_flags) > -hostrust_flags = $(_hostrust_flags) This was originally meant to be consistent with C and C++ indeed, but if you prefer less variables, I guess it is fine, in which case, should we update the C/C++ side too (in another series)? Reviewed-by: Miguel Ojeda <ojeda@...nel.org> Tested-by: Miguel Ojeda <ojeda@...nel.org> Cheers, Miguel
Powered by blists - more mailing lists