linux-kernel - Re: [PATCH] scsi: ufs: core: fix devfreq deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85e91255-1e6f-f428-5376-08416d2107a2@acm.org>
Date:   Tue, 3 Jan 2023 13:45:21 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Johan Hovold <johan+linaro@...nel.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Can Guo <quic_cang@...cinc.com>
Subject: Re: [PATCH] scsi: ufs: core: fix devfreq deadlocks

On 12/22/22 02:21, Johan Hovold wrote:
> +	/* Enable Write Booster if we have scaled up else disable it */
> +	if (ufshcd_enable_wb_if_scaling_up(hba))
> +		ufshcd_wb_toggle(hba, scale_up);

Hi Asutosh,

This patch is the second complaint about the mechanism that toggles the 
WriteBooster during clock scaling. Can this mechanism be removed entirely?

I think this commit introduced that mechanism: 3d17b9b5ab11 ("scsi: ufs: 
Add write booster feature support"; v5.8).

Thanks,

Bart.