linux-kernel - Re: [PATCH] time: fix various kernel-doc problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Jan 2023 13:41:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev,
        Randy Dunlap <rdunlap@...radead.org>,
        John Stultz <jstultz@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] time: fix various kernel-doc problems

Hi Randy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/timers/core]
[also build test WARNING on tip/timers/nohz linus/master v6.2-rc2 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Randy-Dunlap/time-fix-various-kernel-doc-problems/20230103-113048
patch link:    https://lore.kernel.org/r/20230103032849.12723-1-rdunlap%40infradead.org
patch subject: [PATCH] time: fix various kernel-doc problems
config: mips-allmodconfig
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/856bf2d268b0558b5f99d7d077f2ab593b068899
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Randy-Dunlap/time-fix-various-kernel-doc-problems/20230103-113048
        git checkout 856bf2d268b0558b5f99d7d077f2ab593b068899
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> kernel/time/tick-oneshot.c:106:5: warning: no previous prototype for 'tick_check_oneshot_mode' [-Wmissing-prototypes]
     106 | int tick_check_oneshot_mode(void)
         |     ^~~~~~~~~~~~~~~~~~~~~~~


vim +/tick_check_oneshot_mode +106 kernel/time/tick-oneshot.c

   100	
   101	/**
   102	 * tick_check_oneshot_mode - check whether the system is in oneshot mode
   103	 *
   104	 * returns 1 when either nohz or highres are enabled. otherwise 0.
   105	 */
 > 106	int tick_check_oneshot_mode(void)
   107	{
   108		unsigned long flags;
   109		int ret;
   110	
   111		local_irq_save(flags);
   112		ret = __this_cpu_read(tick_cpu_device.mode) == TICKDEV_MODE_ONESHOT;
   113		local_irq_restore(flags);
   114	
   115		return ret;
   116	}
   117	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (321274 bytes)