linux-kernel - Re: [PATCH v2] ucsi_ccg: Refine the UCSI Interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a8b1143-7554-2474-e6b2-ccc4e9a369e6@nvidia.com>
Date:   Tue, 3 Jan 2023 08:12:12 +0000
From:   Haotien Hsu <haotienh@...dia.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Sing-Han Chen <singhanc@...dia.com>,
        Sanket Goswami <Sanket.Goswami@....com>,
        Wayne Chang <waynec@...dia.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ucsi_ccg: Refine the UCSI Interrupt handling

On 1/3/23 15:32, Greg Kroah-Hartman wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Jan 03, 2023 at 10:40:23AM +0800, Haotien Hsu wrote:
>> From: Sing-Han Chen <singhanc@...dia.com>
>>
>> For the CCGx, when the OPM field in the INTR_REG is cleared, then the
>> CCI data in the PPM is reset.
>>
>> To align with the CCGx UCSI interface guide, this patch updates the
>> driver to copy CCI and MESSAGE_IN before clearing UCSI interrupt.
>> When a new command is sent, the driver will clear the old CCI and
>> MESSAGE_IN copy.
>>
>> Finally, clear UCSI_READ_INT before calling complete() to ensure that
>> the ucsi_ccg_sync_write() would wait for the interrupt handling to
>> complete.
>> It prevents the driver from resetting CCI prematurely.
>>
>> Signed-off-by: Sing-Han Chen <singhanc@...dia.com>
>> Signed-off-by: Haotien Hsu <haotienh@...dia.com>
>> Reported-by: kernel test robot <lkp@...el.com>
> 
> The test robot reported this whole issue?  If not, it should not be
> here.
> 
> thanks,
> 
> greg k-h
> 
Sorry for misusing tags.