linux-kernel - Re: [PATCH v2 2/5] ASoC: samsung: i2s: add support for FSD I2S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Jan 2023 16:23:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Padmanabhan Rajanbabu <p.rajanbabu@...sung.com>,
        lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, s.nawrocki@...sung.com,
        perex@...ex.cz, tiwai@...e.com, pankaj.dubey@...sung.com,
        alim.akhtar@...sung.com, rcsekar@...sung.com,
        aswani.reddy@...sung.com
Cc:     oe-kbuild-all@...ts.linux.dev, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        Padmanabhan Rajanbabu <p.rajanbabu@...sung.com>
Subject: Re: [PATCH v2 2/5] ASoC: samsung: i2s: add support for FSD I2S

Hi Padmanabhan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on broonie-sound/for-next linus/master v6.2-rc2 next-20221226]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Padmanabhan-Rajanbabu/ASoC-samsung-i2s-add-support-for-FSD-I2S/20230103-144351
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230103045613.100309-3-p.rajanbabu%40samsung.com
patch subject: [PATCH v2 2/5] ASoC: samsung: i2s: add support for FSD I2S
config: alpha-allyesconfig
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/c42e28fadddea95266f0461d538911d06f0d238b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Padmanabhan-Rajanbabu/ASoC-samsung-i2s-add-support-for-FSD-I2S/20230103-144351
        git checkout c42e28fadddea95266f0461d538911d06f0d238b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash sound/soc/samsung/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> sound/soc/samsung/i2s.c:1587:6: warning: no previous prototype for 'fsd_i2s_fixup_early' [-Wmissing-prototypes]
    1587 | void fsd_i2s_fixup_early(struct snd_pcm_substream *substream,
         |      ^~~~~~~~~~~~~~~~~~~
>> sound/soc/samsung/i2s.c:1600:6: warning: no previous prototype for 'fsd_i2s_fixup_late' [-Wmissing-prototypes]
    1600 | void fsd_i2s_fixup_late(struct snd_pcm_substream *substream,
         |      ^~~~~~~~~~~~~~~~~~


vim +/fsd_i2s_fixup_early +1587 sound/soc/samsung/i2s.c

  1586	
> 1587	void fsd_i2s_fixup_early(struct snd_pcm_substream *substream,
  1588			struct snd_soc_dai *dai)
  1589	{
  1590		struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
  1591		struct i2s_dai *i2s = to_info(asoc_rtd_to_cpu(rtd, 0));
  1592		struct i2s_dai *other = get_other_dai(i2s);
  1593	
  1594		if (!is_opened(other)) {
  1595			i2s_set_sysclk(dai, SAMSUNG_I2S_CDCLK, 192, SND_SOC_CLOCK_OUT);
  1596			i2s_set_sysclk(dai, SAMSUNG_I2S_OPCLK, 0, MOD_OPCLK_PCLK);
  1597		}
  1598	}
  1599	
> 1600	void fsd_i2s_fixup_late(struct snd_pcm_substream *substream,
  1601			struct snd_soc_dai *dai)
  1602	{
  1603		struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
  1604		struct samsung_i2s_priv *priv = snd_soc_dai_get_drvdata(dai);
  1605		struct i2s_dai *i2s = to_info(asoc_rtd_to_cpu(rtd, 0));
  1606		struct i2s_dai *other = get_other_dai(i2s);
  1607	
  1608		if (!is_opened(other))
  1609			writel(PSR_PSVAL(2) | PSR_PSREN, priv->addr + I2SPSR);
  1610	}
  1611	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (316663 bytes)