linux-kernel - [PATCH v3 6/8] block, bfq: remove redundant check in bfq_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230103095303.2223546-7-shikemeng@huaweicloud.com>
Date:   Tue,  3 Jan 2023 17:53:01 +0800
From:   Kemeng Shi <shikemeng@...weicloud.com>
To:     jack@...e.com, paolo.valente@...aro.org, axboe@...nel.dk
Cc:     hch@....de, damien.lemoal@...nsource.wdc.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v3 6/8] block, bfq: remove redundant check in bfq_put_cooperator

We have already avoided a circular list in bfq_setup_merge (see comments
in bfq_setup_merge() for details), so bfq_queue will not appear in it's
new_bfqq list. Just remove this check.

Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
Reviewed-by: Jan Kara <jack@...e.cz>
---
 block/bfq-iosched.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index ebcafe3c4c3b..9ff424c78e9b 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -5274,8 +5274,6 @@ void bfq_put_cooperator(struct bfq_queue *bfqq)
 	 */
 	__bfqq = bfqq->new_bfqq;
 	while (__bfqq) {
-		if (__bfqq == bfqq)
-			break;
 		next = __bfqq->new_bfqq;
 		bfq_put_queue(__bfqq);
 		__bfqq = next;
-- 
2.30.0