[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y7QdpAgutLYM4BrX@google.com>
Date: Tue, 3 Jan 2023 12:20:52 +0000
From: Lee Jones <lee@...nel.org>
To: Aren Moynihan <aren@...cevolution.org>
Cc: Chen-Yu Tsai <wens@...e.org>, linux-kernel@...r.kernel.org,
Ondrej Jirman <megi@....cz>,
Samuel Holland <samuel@...lland.org>
Subject: Re: [PATCH v2] mfd: axp20x: fix order of pek rise and fall events
On Thu, 08 Dec 2022, Aren Moynihan wrote:
> The power button can get "stuck" if the rising edge and falling edge irq
> are read in the same pass. This can often be triggered when resuming
> from suspend if the power button is released before the kernel handles
> the interrupt.
>
> Swapping the order of the rise and fall events makes sure that the press
> event is handled first, which prevents this situation.
>
> Signed-off-by: Aren Moynihan <aren@...cevolution.org>
> ---
> changes in v2:
> - add comments describing the reason these are out of bit order
>
> previous version:
> https://lore.kernel.org/lkml/20221123230741.2430813-1-aren@peacevolution.org/T/
>
> include/linux/mfd/axp20x.h | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists