linux-kernel - Re: [PATCH] ACPI: Drop the custom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5639784.DvuYhMxLoT@kreacher>
Date:   Tue, 03 Jan 2023 14:00:29 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "Zhang, Rui" <rui.zhang@...el.com>
Cc:     "zh.nvgt@...il.com" <zh.nvgt@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: Drop the custom_method debugfs interface

On Tuesday, January 3, 2023 3:17:43 AM CET Zhang, Rui wrote:
> On Mon, 2023-01-02 at 18:05 +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > 
> > The ACPI custom_method debugfs interface is security-sensitive and
> > concurrent access to it is broken [1].
> > 
> > Moreover, the recipe for preparing a customized version of a given
> > control method has changed at one point due to ACPICA changes, which
> > has not been reflected in its documentation, so whoever used it
> > before
> > has had to adapt an no problems with it have been reported.
> > 
> > The latter likely means that the number of its users is limited at
> > best
> > and attempting to fix the issues mentioned above is likely not worth
> > the
> > effort.  Moreover, if it gets broken in the process, the breakage may
> > not
> > be readily discovered, so deleting it altogheher appeares to be a
> > better
> > option.
> > 
> > Accordingly, drop custom_method along with its (outdated anyway)
> > documentation.
> > 
> > Link: 
> > https://lore.kernel.org/linux-acpi/20221227063335.61474-1-zh.nvgt@gmail.com/
> > # [1]
> > Reported-by: Hang Zhang <zh.nvgt@...il.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > ---
> >  Documentation/firmware-guide/acpi/method-customizing.rst |   89 ----
> > --------
> 
> Documentation/firmware-guide/acpi/index.rst
> needs to be updated as well.

Right, thanks!

I've just sent a v2 of the patch with that fixed.