[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <393a6418-0963-4859-3212-2f959be4f14f@linux.intel.com>
Date: Tue, 3 Jan 2023 09:13:33 -0600
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Brent Lu <brent.lu@...el.com>, alsa-devel@...a-project.org
Cc: Cezary Rojewski <cezary.rojewski@...el.com>,
Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
Bard Liao <yung-chuan.liao@...ux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
Mark Brown <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Akihiko Odaki <akihiko.odaki@...il.com>,
ye xingchen <ye.xingchen@....com.cn>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: Intel: sof_ssp_amp: remove unused variable
On 1/3/23 01:37, Brent Lu wrote:
> The variable becomes useless since we moved the snd_soc_jack
> structure from a static array to sof_hdmi_pcm structure.
>
> Signed-off-by: Brent Lu <brent.lu@...el.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> ---
> sound/soc/intel/boards/sof_ssp_amp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/sound/soc/intel/boards/sof_ssp_amp.c b/sound/soc/intel/boards/sof_ssp_amp.c
> index 94d25aeb6e7c..f75800d9d6de 100644
> --- a/sound/soc/intel/boards/sof_ssp_amp.c
> +++ b/sound/soc/intel/boards/sof_ssp_amp.c
> @@ -105,7 +105,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
> char jack_name[NAME_SIZE];
> struct sof_hdmi_pcm *pcm;
> int err;
> - int i;
>
> if (!(sof_ssp_amp_quirk & SOF_HDMI_PLAYBACK_PRESENT))
> return 0;
> @@ -124,7 +123,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
> return hda_dsp_hdmi_build_controls(card, component);
> }
>
> - i = 0;
> list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
> component = pcm->codec_dai->component;
> snprintf(jack_name, sizeof(jack_name),
> @@ -139,8 +137,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
> &pcm->sof_hdmi);
> if (err < 0)
> return err;
> -
> - i++;
> }
>
> return hdac_hdmi_jack_port_init(component, &card->dapm);
Powered by blists - more mailing lists