linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8998-yoshino: Use SONY GPIO names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cf079fa7-56cf-2eea-993a-46c60adf5c49@linaro.org>
Date:   Tue, 3 Jan 2023 03:07:42 +0200
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-arm-msm@...r.kernel.org, andersson@...nel.org,
        agross@...nel.org, krzysztof.kozlowski@...aro.org
Cc:     marijn.suijten@...ainline.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8998-yoshino: Use SONY GPIO names

On 02/01/2023 21:01, Konrad Dybcio wrote:
> Sony ever so graciously provides GPIO line names in their downstream
> kernel (though sometimes they are not 100% accurate and you can judge
> that by simply looking at them and with what drivers they are used).
> 
> Add these to the Yoshino devices DTs to better document the hardware and
> rename already-defined GPIO nodes to fit the "official" names.
> Note that 4k_ is replaced with four_k_ in one pin, as labels can't start
> with numbers.
> 
> Lilac and Poplar have identical pin assignments.
> 
> Diff between these two and maple:
> 
> TLMM:
> -  "NC",
> +  "TS_VDDIO_EN",
> 
> PMI8998:
> -  "NC"
> +  "USB_SWITCH_SEL"
> 
> -  "NC"
> +  "4K_DISP_DCDC_EN"
> 
> PM8005:
> -  "NC"
> +  "EAR_EN"
> 
> Which is probably due to Maple being designed and released quite a bit
> earlier than the other two and it having a super high tech true-4K
> display.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>   .../msm8998-sony-xperia-yoshino-maple.dts     | 179 +++++++++++-
>   .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi | 260 +++++++++++++++---


The patch doesn't only add GPIO names, but also changes some labels and 
node names. I can not judge whether they are correct changes or not, but 
they definitely should be split out of the GPIO names patch.


>   2 files changed, 406 insertions(+), 33 deletions(-)
> 
-- 
With best wishes
Dmitry