linux-kernel - Re: [PATCH] time: fix various kernel-doc problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ccd76c3-d516-16e8-8343-6c4881d377f3@infradead.org>
Date:   Tue, 3 Jan 2023 08:54:14 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     linux-kernel@...r.kernel.org, John Stultz <jstultz@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] time: fix various kernel-doc problems

Hi Ingo,

On 1/3/23 02:06, Ingo Molnar wrote:
> 
> * Randy Dunlap <rdunlap@...radead.org> wrote:
> 
>> kernel/time/tick-oneshot.c:107: warning: expecting prototype for tick_check_oneshot_mode(). Prototype was for tick_oneshot_mode_active() instead
> 
>> --- a/kernel/time/tick-oneshot.c
>> +++ b/kernel/time/tick-oneshot.c
> 
>> @@ -103,7 +103,7 @@ int tick_switch_to_oneshot(void (*handle
>>   *
>>   * returns 1 when either nohz or highres are enabled. otherwise 0.
>>   */
>> -int tick_oneshot_mode_active(void)
>> +int tick_check_oneshot_mode(void)
>>  {
>>  	unsigned long flags;
>>  	int ret;
> 
> This one looks wrong - did you change the name on the wrong line?

Yes, sorry about that.

> I've applied your patch, but fixed the above hunk to be:
> 
> @@ -99,7 +99,7 @@ int tick_switch_to_oneshot(void (*handle
>  }
>  
>  /**
> - * tick_check_oneshot_mode - check whether the system is in oneshot mode
> + * tick_oneshot_mode_active - check whether the system is in oneshot mode
>   *
>   * returns 1 when either nohz or highres are enabled. otherwise 0.
>   */
> 
> Thanks,

Thank you also.

-- 
~Randy