linux-kernel - [PATCH v3 0/5] Fix a whole host of nvmem registration/cleanup issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7RezbPSGrO37NZZ@shell.armlinux.org.uk>
Date:   Tue, 3 Jan 2023 16:58:53 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Gaosheng Cui <cuigaosheng1@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Maxime Ripard <mripard@...nel.org>,
        Hector Martin <marcan@...can.st>
Subject: [PATCH v3 0/5] Fix a whole host of nvmem registration/cleanup issues

Hi,

This series fixes a whole host of nvmem registration/error cleanup
issues that have been identified by both Hector and myself. It is a
substantial rework of my original patch fixing the first problem.

The first most obvious problem is the race between nvmem registration
and use, which leads to sporadic failures of drivers to probe at boot
time.

While fixing this, it has been noticed that a recent fix to check the
return value of dev_set_name() introduced a new bug where wp_gpio was
not being put in that newly introduced error path.

Then there's a fix for a previous fix which itself purports to fix
another bug, but results in the allocated ID being leaked. Fix for a
fix for a fix is not good!

Then there's an error in the docbook documentation for wp_gpio (it's
listed as wp-gpio instead) but as nothing seems to set wp_gpio, we
might as well get rid of it - which also solves the issue that we
call gpiod_put() on this whether we own it or not.

Lastly, there's a fix for yet another spurious white-space in this
code, one of what seems to be a long history of past white-space
fixes.

These patches have been individually build-tested in the order of
posting, but not run-time tested except for the entire series.

 drivers/nvmem/core.c           | 51 ++++++++++++++++++------------------------
 include/linux/nvmem-provider.h |  2 --
 2 files changed, 22 insertions(+), 31 deletions(-)

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!