linux-kernel - RE: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TY2PR06MB321306D17A97FBEBFE969A8B80F49@TY2PR06MB3213.apcprd06.prod.outlook.com>
Date:   Tue, 3 Jan 2023 03:37:48 +0000
From:   Neal Liu <neal_liu@...eedtech.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        "David S . Miller" <davem@...emloft.net>,
        ChiaWei Wang <chiawei_wang@...eedtech.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>
Subject: RE: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver

> -----Original Message-----
> From: Herbert Xu <herbert@...dor.apana.org.au>
> Sent: Friday, December 30, 2022 4:29 PM
> To: Neal Liu <neal_liu@...eedtech.com>
> Cc: Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Joel Stanley <joel@....id.au>; Andrew
> Jeffery <andrew@...id.au>; David S . Miller <davem@...emloft.net>;
> ChiaWei Wang <chiawei_wang@...eedtech.com>;
> devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-aspeed@...ts.ozlabs.org; linux-kernel@...r.kernel.org;
> linux-crypto@...r.kernel.org; Christoph Hellwig <hch@...radead.org>
> Subject: Re: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver
> 
> On Wed, Dec 14, 2022 at 03:01:11PM +0800, Neal Liu wrote:
> >
> > +static u8 *aspeed_rsa_key_copy(u8 *src, size_t len) {
> > +	return kmemdup(src, len, GFP_DMA | GFP_KERNEL);
> 
> Please explain why you are using GFP_DMA.

Looks like it's unnecessary. I'll remove it.
Thanks.

> Thanks,
> --
> Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt