linux-kernel - [tip: x86/asm] x86/lib: Fix compiler and kernel-doc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167276840783.4906.14619707136056889151.tip-bot2@tip-bot2>
Date:   Tue, 03 Jan 2023 17:53:27 -0000
From:   "tip-bot2 for Anuradha Weeraman" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Anuradha Weeraman <anuradha@...ian.org>,
        Ingo Molnar <mingo@...nel.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: x86/asm] x86/lib: Fix compiler and kernel-doc warnings

The following commit has been merged into the x86/asm branch of tip:

Commit-ID:     65c24d7b0f9142c6acc9bd6dabeba22767077681
Gitweb:        https://git.kernel.org/tip/65c24d7b0f9142c6acc9bd6dabeba22767077681
Author:        Anuradha Weeraman <anuradha@...ian.org>
AuthorDate:    Tue, 03 Jan 2023 17:17:24 +05:30
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Tue, 03 Jan 2023 18:46:21 +01:00

x86/lib: Fix compiler and kernel-doc warnings

Fix the following W=1 warnings:

arch/x86/lib/cmdline.c:

  - Include <asm/cmdline.h> to fix missing-prototypes warnings.

  - Update comment for __cmdline_find_option_bool to fix a kernel-doc warning.

Signed-off-by: Anuradha Weeraman <anuradha@...ian.org>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
Link: https://lore.kernel.org/r/20230103114725.108431-1-anuradha@debian.org
---
 arch/x86/lib/cmdline.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/lib/cmdline.c b/arch/x86/lib/cmdline.c
index b6da093..80570eb 100644
--- a/arch/x86/lib/cmdline.c
+++ b/arch/x86/lib/cmdline.c
@@ -7,16 +7,18 @@
 #include <linux/string.h>
 #include <linux/ctype.h>
 #include <asm/setup.h>
+#include <asm/cmdline.h>
 
 static inline int myisspace(u8 c)
 {
 	return c <= ' ';	/* Close enough approximation */
 }
 
-/**
+/*
  * Find a boolean option (like quiet,noapic,nosmp....)
  *
  * @cmdline: the cmdline string
+ * @max_cmdline_size: the maximum size of cmdline
  * @option: option string to look for
  *
  * Returns the position of that @option (starts counting with 1)