linux-kernel - Re: [PATCH] xfs: xfs_qm: remove unnecessary ‘0’ values from error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7Ru73JbumMnTEqc@magnolia>
Date:   Tue, 3 Jan 2023 10:07:43 -0800
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Li zeming <zeming@...china.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: xfs_qm: remove unnecessary ‘0’ values from error

On Fri, Dec 23, 2022 at 04:11:14PM +0800, Li zeming wrote:
> error is assigned first, so it does not need to initialize the
> assignment.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

Looks fine to me...
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
>  fs/xfs/xfs_qm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index ff53d40a2dae..e2c542f6dcd4 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -68,7 +68,7 @@ xfs_qm_dquot_walk(
>  
>  	while (1) {
>  		struct xfs_dquot *batch[XFS_DQ_LOOKUP_BATCH];
> -		int		error = 0;
> +		int		error;
>  		int		i;
>  
>  		mutex_lock(&qi->qi_tree_lock);
> -- 
> 2.18.2
>