linux-kernel - RE: [PATCH] x86/mce: Mask out non-address bits from machine check bank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2023 20:35:06 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Yazen Ghannam <yazen.ghannam@....com>
CC:     Borislav Petkov <bp@...en8.de>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "Du, Fan" <fan.du@...el.com>
Subject: RE: [PATCH] x86/mce: Mask out non-address bits from machine check
 bank

>> +/* MCi_ADDR register defines */
>> +#define MCI_ADDR_PHYSADDR	GENMASK(boot_cpu_data.x86_phys_bits - 1, 0)
>
> Should this use GENMASK_ULL in case we're running in 32-bit mode?

Indeed it should! Thanks for the catch.  Also for the review.

-Tony