linux-kernel - Re: [PATCH] cgroup/cpuset: no need to explicitly init a global static variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2023 12:21:54 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Daniel Vacek <neelx@...hat.com>
Cc:     Waiman Long <longman@...hat.com>,
        Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cgroup/cpuset: no need to explicitly init a global
 static variable

On Tue, Dec 20, 2022 at 04:14:15PM +0100, Daniel Vacek wrote:
> cpuset_rwsem is a static variable. It's initialized at build time and so
> there's no need for explicit runtime init leaking one percpu int.
> 
> Signed-off-by: Daniel Vacek <neelx@...hat.com>

Applied to cgroup/for-6.2-fixes with the following description:

    cgroup/cpuset: no need to explicitly init a global static variable
    
    cpuset_rwsem is a static variable defined with DEFINE_STATIC_PERCPU_RWSEM().
    It's initialized at build time and so there's no need for explicit runtime
    init leaking one percpu int.
    
    Signed-off-by: Daniel Vacek <neelx@...hat.com>
    Reviewed-by: Aaron Tomlin <atomlin@...mlin.com>
    Acked-by: Mukesh Ojha <quic_mojha@...cinc.com>
    Signed-off-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun