linux-kernel - Re: [PATCH v2 1/7] powerpc/pseries: Log hcall return codes for PLPKS debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9b726fad8a4c543f278a9156f81475f5e8fab5c.camel@linux.ibm.com>
Date:   Wed, 04 Jan 2023 15:45:22 +1100
From:   Andrew Donnellan <ajd@...ux.ibm.com>
To:     Russell Currey <ruscur@...sell.cc>, linuxppc-dev@...ts.ozlabs.org
Cc:     gregkh@...uxfoundation.org, gcwilson@...ux.ibm.com,
        linux-kernel@...r.kernel.org, nayna@...ux.ibm.com,
        zohar@...ux.ibm.com, mpe@...erman.id.au
Subject: Re: [PATCH v2 1/7] powerpc/pseries: Log hcall return codes for
 PLPKS debug

On Fri, 2022-12-30 at 15:20 +1100, Russell Currey wrote:
> The plpks code converts hypervisor return codes into their Linux
> equivalents so that users can understand them.  Having access to the
> original return codes is really useful for debugging, so add a
> pr_debug() so we don't lose information from the conversion.
> 
> Signed-off-by: Russell Currey <ruscur@...sell.cc>

This is indeed useful to have.

Reviewed-by: Andrew Donnellan <ajd@...ux.ibm.com>
Tested-by: Andrew Donnellan <ajd@...ux.ibm.com>

> ---
>  arch/powerpc/platforms/pseries/plpks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/platforms/pseries/plpks.c
> b/arch/powerpc/platforms/pseries/plpks.c
> index 9e4401aabf4f..820218eb894f 100644
> --- a/arch/powerpc/platforms/pseries/plpks.c
> +++ b/arch/powerpc/platforms/pseries/plpks.c
> @@ -131,6 +131,8 @@ static int pseries_status_to_err(int rc)
>                 err = -EINVAL;
>         }
>  
> +       pr_debug("Converted hypervisor code %d to Linux %d\n", rc,
> err);
> +
>         return err;
>  }
>  

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited