linux-kernel - Re: [PATCH V5 2/3] PCI: Create device tree node for selected devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7eb33924fc380669893571747b999660@bootlin.com>
Date:   Wed, 04 Jan 2023 06:57:14 +0100
From:   clement.leger@...tlin.com
To:     Lizhi Hou <lizhi.hou@....com>
Cc:     linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh@...nel.org,
        frowand.list@...il.com, helgaas@...nel.org, max.zhen@....com,
        sonal.santan@....com, larry.liu@....com, brian.xu@....com,
        stefano.stabellini@...inx.com, trix@...hat.com,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Allan.Nielsen@...rochip.com, Horatiu.Vultur@...rochip.com,
        Steen.Hegelund@...rochip.com
Subject: Re: [PATCH V5 2/3] PCI: Create device tree node for selected devices

Le 2023-01-04 01:31, Lizhi Hou a écrit :
> On 1/3/23 06:48, Clément Léger wrote:
>> Le Thu, 15 Dec 2022 09:30:45 -0800,
>> Lizhi Hou <lizhi.hou@....com> a écrit :
>> 
>>> +
>>> +static int of_pci_prop_address_cells(struct pci_dev *pdev,
>>> +				     struct of_changeset *ocs,
>>> +				     struct device_node *np)
>>> +{
>>> +	return of_changeset_add_prop_u32(ocs, np, "#address_cells",
>>> +					 OF_PCI_ADDRESS_CELLS);
>>> +}
>> Hi Lizhi,
>> 
>> This should be #address-cells and not #address_cells.
>> 
>>> +
>>> +static int of_pci_prop_size_cells(struct pci_dev *pdev,
>>> +				  struct of_changeset *ocs,
>>> +				  struct device_node *np)
>>> +{
>>> +	return of_changeset_add_prop_u32(ocs, np, "#size_cells",
>>> +					 OF_PCI_SIZE_CELLS);
>>> +}
>> Ditto here, this should be #size-cells and not #size_cells. Was this
>> really tested ?
> 
> I will fix this.  I verified the properties are generated and did not
> notice the '_' error.

Hi Lizhi,

The most important thing to test is if a driver can correctly retrieve 
resource
of the device using a node added below the created PCI device node. This 
is
resolved using the whole hierarchy ranges, address-cells and size-cells 
properties.

If not correctly set, this will fail (and it fails).

Clément

> 
> 
> Thanks,
> 
> Lizhi
> 
>> 
>> Thanks,
>>