linux-kernel - Re: [PATCH] x86/xen: Remove the unused function p2m_top_mfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d272122f-8459-075e-f2b5-476b2ddf7405@suse.com>
Date:   Wed, 4 Jan 2023 09:31:36 +0100
From:   Jan Beulich <jbeulich@...e.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     boris.ostrovsky@...cle.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, xen-devel@...ts.xenproject.org,
        linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>, jgross@...e.com
Subject: Re: [PATCH] x86/xen: Remove the unused function p2m_top_mfn_init()

On 27.12.2022 09:21, Jiapeng Chong wrote:
> The function p2m_top_mfn_init is defined in the p2m.c file,
> but not called elsewhere, so remove this unused function.

This and the title are wrong - p2m_top_mfn_init() is used by
xen_build_mfn_list_list().

> arch/x86/xen/p2m.c:137:24: warning: unused function 'p2m_index'.

Whereas this and the actual code change look correct to me.

Jan