linux-kernel - Re: [PATCH v2] soc: imx8m: fix wrong return value check of of_clk_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31d7df1d-f77e-94df-942e-3d703c414a76@pengutronix.de>
Date:   Wed, 4 Jan 2023 10:19:28 +0100
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     xiaolei.wang@...driver.com, alexander.stein@...tq-group.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, linux-imx@....com,
        kernel@...gutronix.de, festevam@...il.com, l.stach@...gutronix.de
Subject: Re: [PATCH v2] soc: imx8m: fix wrong return value check of
 of_clk_get_by_name()

On 04.01.23 10:27, Yang Yingliang wrote:
> of_clk_get_by_name() never returns NULL pointer, it will return
> ERR_PTR() when it fails, so replace the check with IS_ERR().
> 
> Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

> ---
> v1 -> v2:
>   Check WARN_ON() instead of checking IS_ERR().
> ---
>  drivers/soc/imx/soc-imx8m.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 28144c699b0c..d1dbe318be53 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -66,10 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
>  	ocotp_base = of_iomap(np, 0);
>  	WARN_ON(!ocotp_base);
>  	clk = of_clk_get_by_name(np, NULL);
> -	if (!clk) {
> -		WARN_ON(!clk);
> +	if (WARN_ON(IS_ERR(clk)))
>  		return 0;
> -	}
>  
>  	clk_prepare_enable(clk);
>  

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |