linux-kernel - Re: [PATCH] of/fdt: run soc memory setup when early_init_dt_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <167279286226.159538.13769216021607958062.robh@kernel.org>
Date:   Tue, 3 Jan 2023 18:41:03 -0600
From:   Rob Herring <robh@...nel.org>
To:     andreas@...mhold.de
Cc:     devicetree@...r.kernel.org, stable@...r.kernel.org,
        John Crispin <john@...ozen.org>,
        Rob Herring <robh+dt@...nel.org>, linux-mips@...r.kernel.org,
        Frank Rowand <frowand.list@...il.com>,
        linux-kernel@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [PATCH] of/fdt: run soc memory setup when
 early_init_dt_scan_memory fails


On Fri, 23 Dec 2022 12:27:47 +0100, andreas@...mhold.de wrote:
> From: Andreas Rammhold <andreas@...mhold.de>
> 
> If memory has been found early_init_dt_scan_memory now returns 1. If
> it hasn't found any memory it will return 0, allowing other memory
> setup mechanisms to carry on.
> 
> Previously early_init_dt_scan_memory always returned 0 without
> distinguishing between any kind of memory setup being done or not. Any
> code path after the early_init_dt_scan memory call in the ramips
> plat_mem_setup code wouldn't be executed anymore. Making
> early_init_dt_scan_memory the only way to initialize the memory.
> 
> Some boards, including my mt7621 based Cudy X6 board, depend on memory
> initialization being done via the soc_info.mem_detect function
> pointer. Those wouldn't be able to obtain memory and panic the kernel
> during early bootup with the message "early_init_dt_alloc_memory_arch:
> Failed to allocate 12416 bytes align=0x40".
> 
> Fixes: 1f012283e936 ("of/fdt: Rework early_init_dt_scan_memory() to call directly")
> Cc: stable@...r.kernel.org
> Signed-off-by: Andreas Rammhold <andreas@...mhold.de>
> ---
>  arch/mips/ralink/of.c | 2 +-
>  drivers/of/fdt.c      | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 

Applied, thanks!