[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <167279301050.163217.7817410182620857350.robh@kernel.org>
Date: Tue, 3 Jan 2023 18:43:31 -0600
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: linux-kernel@...r.kernel.org, Andy Gross <agross@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
linux-arm-msm@...r.kernel.org,
Kishon Vijay Abraham I <kishon@...nel.org>,
linux-phy@...ts.infradead.org,
Bjorn Andersson <andersson@...nel.org>,
Wesley Cheng <quic_wcheng@...cinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
devicetree@...r.kernel.org, Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH 1/4] dt-bindings: phy: qcom,usb-snps-femto-v2: use
fallback compatibles
On Fri, 23 Dec 2022 17:18:32 +0100, Krzysztof Kozlowski wrote:
> Document SoC-specific compatibles with generic fallback (e.g.
> qcom,usb-snps-hs-7nm-phy) already used in DTSI. Add SoC-specific
> compatibles for PHY on SDX55 and SDX65.
>
> This disallows usage of the qcom,usb-snps-hs-5nm-phy and
> qcom,usb-snps-hs-7nm-phy generic compatibles alone. Do not touch
> remaining two compatibles - qcom,usb-snps-femto-v2-phy and
> qcom,sc8180x-usb-hs-phy - because there are no upstream users, so not
> sure what was the intention for them.
>
> This fixes warnings like:
>
> sa8295p-adp.dtb: phy@...5000: compatible: 'oneOf' conditional failed, one must be fixed:
> ['qcom,sc8280xp-usb-hs-phy', 'qcom,usb-snps-hs-5nm-phy'] is too long
> 'qcom,sc8280xp-usb-hs-phy' is not one of ['qcom,sm8150-usb-hs-phy', 'qcom,sm8250-usb-hs-phy', 'qcom,sm8350-usb-hs-phy', 'qcom,sm8450-usb-hs-phy']
> 'qcom,usb-snps-hs-7nm-phy' was expected
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 33 +++++++++++--------
> 1 file changed, 20 insertions(+), 13 deletions(-)
>
Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists