linux-kernel - Re: [PATCH v1 1/1] media: i2c: st-vgxy61: Use asm intead of asm-generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y7VS2LuKGVQkcyrU@smile.fi.intel.com>
Date:   Wed, 4 Jan 2023 12:20:08 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Benjamin Mugnier <benjamin.mugnier@...s.st.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sylvain Petinot <sylvain.petinot@...s.st.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: st-vgxy61: Use asm intead of
 asm-generic

On Wed, Jan 04, 2023 at 10:27:14AM +0100, Benjamin Mugnier wrote:
> On 1/3/23 15:52, Andy Shevchenko wrote:

...

> > -#include <asm-generic/unaligned.h>
> >  #include <linux/clk.h>
> >  #include <linux/delay.h>
> >  #include <linux/gpio/consumer.h>
> > @@ -15,6 +14,9 @@
> >  #include <linux/pm_runtime.h>
> >  #include <linux/regulator/consumer.h>
> >  #include <linux/units.h>
> > +
> > +#include <asm/unaligned.h>

> Any particular reason not to keep the alphabetical sort ?

It's kept in an order in each of the groups of headers.

The main rule here is to go from most generic headers to the particular ones.
asm/* are definitely more particular than linux/* ones.

> >  #include <media/mipi-csi2.h>
> >  #include <media/v4l2-async.h>
> >  #include <media/v4l2-ctrls.h>

-- 
With Best Regards,
Andy Shevchenko