| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Jan 2023 08:13:46 +0800
From: kernel test robot <lkp@...el.com>
To: Kefeng Wang <wangkefeng.wang@...wei.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Catalin Marinas <catalin.marinas@....com>
Subject: drivers/bus/fsl-mc/dprc.c:494:9: warning: 'strncpy' specified bound
16 equals destination size
Hi Kefeng,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 69b41ac87e4a664de78a395ff97166f0b2943210
commit: dd03762ab608e058c8f390ad9cf667e490089796 arm64: Enable KCSAN
date: 1 year, 1 month ago
config: arm64-randconfig-r012-20230103
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd03762ab608e058c8f390ad9cf667e490089796
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout dd03762ab608e058c8f390ad9cf667e490089796
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/bus/fsl-mc/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/bus/fsl-mc/dprc.c: In function 'dprc_get_obj':
drivers/bus/fsl-mc/dprc.c:453:9: warning: 'strncpy' output may be truncated copying 15 bytes from a string of length 15 [-Wstringop-truncation]
453 | strncpy(obj_desc->type, rsp_params->type, 16);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bus/fsl-mc/dprc.c:455:9: warning: 'strncpy' output may be truncated copying 15 bytes from a string of length 15 [-Wstringop-truncation]
455 | strncpy(obj_desc->label, rsp_params->label, 16);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bus/fsl-mc/dprc.c: In function 'dprc_set_obj_irq':
>> drivers/bus/fsl-mc/dprc.c:494:9: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
494 | strncpy(cmd_params->obj_type, obj_type, 16);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bus/fsl-mc/dprc.c: In function 'dprc_get_obj_region':
drivers/bus/fsl-mc/dprc.c:567:9: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation]
567 | strncpy(cmd_params->obj_type, obj_type, 16);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/strncpy +494 drivers/bus/fsl-mc/dprc.c
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 404
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 405 /**
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 406 * dprc_get_obj() - Get general information on an object
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 407 * @mc_io: Pointer to MC portal's I/O object
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 408 * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 409 * @token: Token of DPRC object
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 410 * @obj_index: Index of the object to be queried (< obj_count)
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 411 * @obj_desc: Returns the requested object descriptor
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 412 *
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 413 * The object descriptors are retrieved one by one by incrementing
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 414 * obj_index up to (not including) the value of obj_count returned
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 415 * from dprc_get_obj_count(). dprc_get_obj_count() must
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 416 * be called prior to dprc_get_obj().
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 417 *
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 418 * Return: '0' on Success; Error code otherwise.
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 419 */
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 420 int dprc_get_obj(struct fsl_mc_io *mc_io,
ba72f25b2588e1 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-25 421 u32 cmd_flags,
ba72f25b2588e1 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-25 422 u16 token,
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 423 int obj_index,
0cf9f5096da220 drivers/staging/fsl-mc/bus/dprc.c Laurentiu Tudor 2017-06-27 424 struct fsl_mc_obj_desc *obj_desc)
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 425 {
5b04cedeca1888 drivers/bus/fsl-mc/dprc.c Ioana Ciornei 2018-03-15 426 struct fsl_mc_command cmd = { 0 };
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 427 struct dprc_cmd_get_obj *cmd_params;
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 428 struct dprc_rsp_get_obj *rsp_params;
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 429 int err;
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 430
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 431 /* prepare command */
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 432 cmd.header = mc_encode_cmd_header(DPRC_CMDID_GET_OBJ,
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 433 cmd_flags,
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 434 token);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 435 cmd_params = (struct dprc_cmd_get_obj *)cmd.params;
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 436 cmd_params->obj_index = cpu_to_le32(obj_index);
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 437
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 438 /* send command to mc*/
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 439 err = mc_send_command(mc_io, &cmd);
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 440 if (err)
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 441 return err;
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 442
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 443 /* retrieve response parameters */
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 444 rsp_params = (struct dprc_rsp_get_obj *)cmd.params;
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 445 obj_desc->id = le32_to_cpu(rsp_params->id);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 446 obj_desc->vendor = le16_to_cpu(rsp_params->vendor);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 447 obj_desc->irq_count = rsp_params->irq_count;
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 448 obj_desc->region_count = rsp_params->region_count;
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 449 obj_desc->state = le32_to_cpu(rsp_params->state);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 450 obj_desc->ver_major = le16_to_cpu(rsp_params->version_major);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 451 obj_desc->ver_minor = le16_to_cpu(rsp_params->version_minor);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 452 obj_desc->flags = le16_to_cpu(rsp_params->flags);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 @453 strncpy(obj_desc->type, rsp_params->type, 16);
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 454 obj_desc->type[15] = '\0';
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 455 strncpy(obj_desc->label, rsp_params->label, 16);
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 456 obj_desc->label[15] = '\0';
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 457 return 0;
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 458 }
c9d57ea0b6fb0b drivers/staging/fsl-mc/bus/dprc.c Laurentiu Tudor 2017-11-17 459 EXPORT_SYMBOL_GPL(dprc_get_obj);
31c889653c10dd drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-03-05 460
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 461 /**
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 462 * dprc_set_obj_irq() - Set IRQ information for object to trigger an interrupt.
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 463 * @mc_io: Pointer to MC portal's I/O object
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 464 * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 465 * @token: Token of DPRC object
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 466 * @obj_type: Type of the object to set its IRQ
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 467 * @obj_id: ID of the object to set its IRQ
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 468 * @irq_index: The interrupt index to configure
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 469 * @irq_cfg: IRQ configuration
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 470 *
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 471 * Return: '0' on Success; Error code otherwise.
e9bf3f206bd5e6 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-24 472 */
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 473 int dprc_set_obj_irq(struct fsl_mc_io *mc_io,
ba72f25b2588e1 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-25 474 u32 cmd_flags,
ba72f25b2588e1 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-25 475 u16 token,
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 476 char *obj_type,
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 477 int obj_id,
ba72f25b2588e1 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-25 478 u8 irq_index,
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 479 struct dprc_irq_cfg *irq_cfg)
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 480 {
5b04cedeca1888 drivers/bus/fsl-mc/dprc.c Ioana Ciornei 2018-03-15 481 struct fsl_mc_command cmd = { 0 };
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 482 struct dprc_cmd_set_obj_irq *cmd_params;
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 483
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 484 /* prepare command */
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 485 cmd.header = mc_encode_cmd_header(DPRC_CMDID_SET_OBJ_IRQ,
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 486 cmd_flags,
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 487 token);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 488 cmd_params = (struct dprc_cmd_set_obj_irq *)cmd.params;
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 489 cmd_params->irq_val = cpu_to_le32(irq_cfg->val);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 490 cmd_params->irq_index = irq_index;
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 491 cmd_params->irq_addr = cpu_to_le64(irq_cfg->paddr);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 492 cmd_params->irq_num = cpu_to_le32(irq_cfg->irq_num);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 493 cmd_params->obj_id = cpu_to_le32(obj_id);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 @494 strncpy(cmd_params->obj_type, obj_type, 16);
9989b59961a8ad drivers/staging/fsl-mc/bus/dprc.c Ioana Radulescu 2016-06-22 495 cmd_params->obj_type[15] = '\0';
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 496
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 497 /* send command to mc*/
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 498 return mc_send_command(mc_io, &cmd);
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 499 }
c9d57ea0b6fb0b drivers/staging/fsl-mc/bus/dprc.c Laurentiu Tudor 2017-11-17 500 EXPORT_SYMBOL_GPL(dprc_set_obj_irq);
1ee695fab32e25 drivers/staging/fsl-mc/bus/dprc.c J. German Rivera 2015-09-23 501
:::::: The code at line 494 was first introduced by commit
:::::: 9989b59961a8ad55d92df4588b556f0c6c838ec7 staging: fsl-mc: convert mc command build/parse to use C structs
:::::: TO: Ioana Radulescu <ruxandra.radulescu@....com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (154394 bytes)
Powered by blists - more mailing lists