linux-kernel - Re: [PATCH] media: platform: ti: Add missing check for devm_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7VwPOQtKC1eDGg+@pendragon.ideasonboard.com>
Date:   Wed, 4 Jan 2023 14:25:32 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: platform: ti: Add missing check for
 devm_regulator_get

Hi Jiasheng,

Thank you for the patch.

On Wed, Jan 04, 2023 at 04:55:37PM +0800, Jiasheng Jiang wrote:
> Add check for the return value of devm_regulator_get since it may return
> error pointer.
> 
> Fixes: 448de7e7850b ("[media] omap3isp: OMAP3 ISP core")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/platform/ti/omap3isp/isp.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/media/platform/ti/omap3isp/isp.c b/drivers/media/platform/ti/omap3isp/isp.c
> index 1d40bb59ff81..e7327e38482d 100644
> --- a/drivers/media/platform/ti/omap3isp/isp.c
> +++ b/drivers/media/platform/ti/omap3isp/isp.c
> @@ -2307,7 +2307,16 @@ static int isp_probe(struct platform_device *pdev)
>  
>  	/* Regulators */
>  	isp->isp_csiphy1.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy1");
> +	if (IS_ERR(isp->isp_csiphy1.vdd)) {
> +		ret = PTR_ERR(isp->isp_csiphy1.vdd);
> +		goto error;
> +	}
> +
>  	isp->isp_csiphy2.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy2");
> +	if (IS_ERR(isp->isp_csiphy2.vdd)) {
> +		ret = PTR_ERR(isp->isp_csiphy2.vdd);
> +		goto error;
> +	}
>  
>  	/* Clocks
>  	 *

-- 
Regards,

Laurent Pinchart