linux-kernel - Re: [PATCH v4 1/3] certs: make blacklisted hash available in klog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y7VxkG0ZsfJEyuFP@kernel.org>
Date:   Wed, 4 Jan 2023 12:31:12 +0000
From:   ", Jarkko Sakkinen" <jarkko@...nel.org>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     David Howells <dhowells@...hat.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Paul Moore <paul@...l-moore.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Mickaël Salaün <mic@...ikod.net>,
        keyrings@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Mark Pearson <markpearson@...ovo.com>
Subject: Re: [PATCH v4 1/3] certs: make blacklisted hash available in klog

On Wed, Dec 21, 2022 at 02:08:22AM +0000, Thomas Weißschuh wrote:
> One common situation triggering this log statement are duplicate hashes
> reported by the system firmware.
> 
> These duplicates should be removed from the firmware.
> 
> Without logging the blacklisted hash triggering the issue however the users
> can not report it properly to the firmware vendors and the firmware vendors
> can not easily see which specific hash is duplicated.
> 
> While changing the log message also use the dedicated ERR_PTR format
> placeholder for the returned error value.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
>  certs/blacklist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/certs/blacklist.c b/certs/blacklist.c
> index 41f10601cc72..6e260c4b6a19 100644
> --- a/certs/blacklist.c
> +++ b/certs/blacklist.c
> @@ -192,7 +192,7 @@ static int mark_raw_hash_blacklisted(const char *hash)
>  				   KEY_ALLOC_NOT_IN_QUOTA |
>  				   KEY_ALLOC_BUILT_IN);
>  	if (IS_ERR(key)) {
> -		pr_err("Problem blacklisting hash (%ld)\n", PTR_ERR(key));
> +		pr_err("Problem blacklisting hash %s: %pe\n", hash, key);
>  		return PTR_ERR(key);
>  	}
>  	return 0;
> 
> -- 
> 2.39.0

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko