linux-kernel - Re: [PATCH AUTOSEL 6.1 1/7] ASoC: SOF: Revert: "core: unregister clients and machine drivers in .shutdown"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2301041427580.3532114@eliteleevi.tm.intel.com>
Date:   Wed, 4 Jan 2023 14:34:55 +0200 (EET)
From:   Kai Vehmanen <kai.vehmanen@...ux.intel.com>
To:     Sasha Levin <sashal@...nel.org>
cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Ricardo Ribalda <ribalda@...omium.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>, lgirdwood@...il.com,
        yung-chuan.liao@...ux.intel.com, daniel.baluta@....com,
        Jaroslav Kysela <perex@...ex.cz>, tiwai@...e.com,
        sound-open-firmware@...a-project.org,
        Alsa-devel <alsa-devel@...a-project.org>
Subject: Re: [PATCH AUTOSEL 6.1 1/7] ASoC: SOF: Revert: "core: unregister
 clients and machine drivers in .shutdown"

Hi,

On Sat, 31 Dec 2022, Sasha Levin wrote:

> From: Kai Vehmanen <kai.vehmanen@...ux.intel.com>
> 
> [ Upstream commit 44fda61d2bcfb74a942df93959e083a4e8eff75f ]
> 
> The unregister machine drivers call is not safe to do when
> kexec is used. Kexec-lite gets blocked with following backtrace:

this should be picked together with commit 2aa2a5ead0e ("ASoC: SOF: Intel: 
pci-tgl: unblock S5 entry if DMA stop has failed"), to not bring back old 
bugs (system failures to enter S5 on shutdown). The revert patch 
unfortunately fails to mention this dependency.

If I'm too late with my reply, I can send the second patch separately to 
stable.

Br, Kai