linux-kernel - Re: [PATCH] staging: media: ipu3: buffer overflow fix in imgu_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Jan 2023 16:33:07 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     Aleksandr Burakov <a.burakov@...alinux.ru>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        linux-media@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] staging: media: ipu3: buffer overflow fix in
 imgu_map_node

On Mon, Jan 02, 2023 at 01:41:21PM +0000, Sakari Ailus wrote:
> > diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c
> > index 0c453b37f8c4..cb09eb3cc227 100644
> > --- a/drivers/staging/media/ipu3/ipu3.c
> > +++ b/drivers/staging/media/ipu3/ipu3.c
> > @@ -60,8 +60,10 @@ unsigned int imgu_map_node(struct imgu_device *imgu, unsigned int css_queue)
> >  	for (i = 0; i < IMGU_NODE_NUM; i++)
> >  		if (imgu_node_map[i].css_queue == css_queue)
> >  			break;
> > -
> > -	return i;
> > +	if (i < IMGU_NODE_NUM)
> > +		return i;
> > +	else
> > +		return (IMGU_NODE_NUM - 1);
> >  }
> >  
> >  /**************** Dummy buffers ****************/
> 
> Thanks for the patch. It would require a bug elsewhere in the driver for
> this to happen. If some handling for this case is added, it shouldn't be
> hiding the issue.
> 
> One easy way could be to add WARN_ON() for this, and return some value (as
> you do). Zero would do equally well.
> 
> I.e.
> 
> 	return WARN_ON(i >= IMGU_NODE_NUM) ? 0 : i;
> 

I sent basically the same response but somehow my email never went
through...  I'm using mutt with gmail Oauth2 and msmtp and so my
weekly(?) login has expired then something silently eats my outgoing
emails.

In this case the emails that I sent directly before and after went
through so it seems like my login wasn't expired or everything would
have been eaten.

This Oauth2 transition has just been so frustrating.  Am I the only
person having trouble with it?

regards,
dan carpenter